Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-OffRamp - batch report execution #811

Merged
merged 11 commits into from
May 15, 2024

Conversation

elatoskinas
Copy link
Collaborator

@elatoskinas elatoskinas commented May 6, 2024

Motivation

Implements batch report execution in the MuiltiOffRamp, allowing to include more than one source chain's report into the execute function.

Solution

Introduces a _batchExecute call and switches _report to accept an array and use the batch execution mode.

Focus: The focus of this PR is the execution logic and batch execution update

Out of scope for this PR:

  • Upgradability handling & test coverage for execute_upgrade
  • ARL / MultiCommitStore integrations

@elatoskinas elatoskinas added the do not merge Do not merge at this time label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

Copy link
Contributor

github-actions bot commented May 6, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Copy link
Contributor

github-actions bot commented May 6, 2024

LCOV of commit 4799cb0 during Solidity Foundry #4336

Summary coverage rate:
  lines......: 98.8% (1192 of 1207 lines)
  functions..: 96.3% (261 of 271 functions)
  branches...: 92.3% (480 of 520 branches)

Files changed coverage rate: n/a

@elatoskinas elatoskinas marked this pull request as ready for review May 6, 2024 12:25
@elatoskinas elatoskinas force-pushed the feat/multi-offramp-execution-states branch from e8f9f90 to f3ee833 Compare May 8, 2024 13:26
@elatoskinas elatoskinas requested a review from a team as a code owner May 8, 2024 13:26
@elatoskinas elatoskinas force-pushed the feat/multi-offramp-batch-execution branch from e5657f6 to 6ca6b86 Compare May 8, 2024 13:51
Copy link
Contributor

github-actions bot commented May 8, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Base automatically changed from feat/multi-offramp-execution-states to ccip-develop May 9, 2024 14:40
@elatoskinas elatoskinas force-pushed the feat/multi-offramp-batch-execution branch from 6ca6b86 to 6bcac3b Compare May 9, 2024 15:00
@elatoskinas elatoskinas removed the do not merge Do not merge at this time label May 9, 2024
@elatoskinas elatoskinas force-pushed the feat/multi-offramp-batch-execution branch from 11f4b0a to cc64cf6 Compare May 13, 2024 15:56
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@elatoskinas elatoskinas enabled auto-merge (squash) May 15, 2024 09:41
@elatoskinas elatoskinas merged commit 451621f into ccip-develop May 15, 2024
82 of 83 checks passed
@elatoskinas elatoskinas deleted the feat/multi-offramp-batch-execution branch May 15, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants