Create multi chain copies for on/off ramps, ARL & commit store #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
LCOV of commit
|
matYang
reviewed
Apr 30, 2024
|
|
||
| import {BaseTest, stdError} from "../BaseTest.t.sol"; | ||
|
|
||
| contract MultieAggregateRateLimiterSetup is BaseTest, PriceRegistrySetup { |
elatoskinas
approved these changes
Apr 30, 2024
|
I see you updated files related to |
|
Go solidity wrappers are out-of-date, regenerate them via the |
matYang
approved these changes
May 1, 2024
RayXpub
added a commit
that referenced
this pull request
May 6, 2024
commit 9686b07 Author: Amir Y <amirylm.dev@gmail.com> Date: Fri May 3 20:06:44 2024 +0300 Make plugin robust against outcome manipulation (#799) ## Motivation The OCR plugin fails to deduplicate the values of slices in each oracle’s reported observation. This allows a single node to introduce duplicate values in its observation slices, causing the plugin to erroneously trust that certain values are the consensus among the DON. ## Solution Extending observation validation to include deduplication validation. commit c8385ba Author: Amir Y <amirylm.dev@gmail.com> Date: Fri May 3 18:48:11 2024 +0300 Change code owners of liquidity manger (#805) commit 9152f0b Author: Ryan Hall <RyanRHall@users.noreply.github.com> Date: Fri May 3 11:29:26 2024 -0400 Add withdrawNative function to Rebalancer contract (#776) ## Motivation We want the ability to withdraw native funds from the LM contract in case we want to migrate those funds to future LM versions ## Solution add a `withdrawNative()` function that only the owner can call commit 91d1e90 Author: Rens Rooimans <github@rensrooimans.nl> Date: Fri May 3 17:09:29 2024 +0200 share change in onramp to multi onramp (#804) Fix ci by applying a change in single-ramp to the multi-ramp commit 7c08043 Author: Amir Y <amirylm.dev@gmail.com> Date: Fri May 3 17:47:12 2024 +0300 Median liquidity per chain fault tolerance validation (#797) ## Motivation Currently, we don’t count values of the reported liquidity in each observation to ensure we have at least f+1 values for each chain, which means that we fail the case of empty values (e.g. an oracle that fails to get the values). ## Solution Count liquidities reported for each chain and ensure the count exceeds the minimum fault tolerance threshold (f+1). commit 73c50c6 Author: Rens Rooimans <github@rensrooimans.nl> Date: Fri May 3 16:17:11 2024 +0200 add isChainSupported to admin registry, reduce permissions of admin (#803) commit 71ae754 Author: Ryan <80392855+RayXpub@users.noreply.github.com> Date: Fri May 3 14:57:00 2024 +0400 Create multi chain copies for on/off ramps, ARL & commit store (#772) ## Motivation Create multi chain copies for the below contracts: - `EVM2EVMOffRamp` -> `EVM2EVMMultiOffRamp` - `EVM2EVMOnRamp` -> `EVM2EVMMultiOnRamp` - `AggregateRateLimiter` -> `MultiAggregateRateLimiter` - `CommitStore` -> `MultiCommitStore` ## Solution New contracts are exact copies of the single chain ones. Some minor changes for CI purposes: - Removed some unused imports - Increased solhint max warnings --------- Co-authored-by: Evaldas Latoskinas <evaldas.latoskinas@smartcontract.com> commit 07337eb Author: Anindita Ghosh <88458927+AnieeG@users.noreply.github.com> Date: Fri May 3 15:48:24 2024 +0530 fix internal ips in crib (#800) ## Motivation ## Solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create multi chain copies for the below contracts:
EVM2EVMOffRamp->EVM2EVMMultiOffRampEVM2EVMOnRamp->EVM2EVMMultiOnRampAggregateRateLimiter->MultiAggregateRateLimiterCommitStore->MultiCommitStoreSolution
New contracts are exact copies of the single chain ones.
Some minor changes for CI purposes: