Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fixes - like typos. #774

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Simple fixes - like typos. #774

wants to merge 4 commits into from

Conversation

phmarek
Copy link
Contributor

@phmarek phmarek commented Jun 8, 2023

No description provided.

@stassats
Copy link
Member

stassats commented Jun 8, 2023

When is fuzzy-completion-set called with a non-simple string?

@phmarek
Copy link
Contributor Author

phmarek commented Jun 8, 2023

When deserializing data via non-default means -- eg. YASON may (in some cases) return non-simple strings.

@phmarek
Copy link
Contributor Author

phmarek commented Jun 8, 2023

Also, I'm using that function to provide completion in a web-interface, and depending on how the string gets built it might not be simple.

As it's a swank internal requirement that the string must be simple, I guess this interface is the right place to ensure it.

@stassats
Copy link
Member

stassats commented Jun 8, 2023

I wouldn't say that swank provides any interface beyond what slime uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants