Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed prettify-symbols-mode bug #717

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ghollisjr
Copy link

Fix for the bug described in Issue #437

@luismbo
Copy link
Member

luismbo commented Apr 27, 2022

Could you explain, perhaps in the commit message, what is going on? TIA.

@luismbo
Copy link
Member

luismbo commented Apr 27, 2022

Ah, I see you've written down your investigation in #437. A cursory look at that raises the question: is this something that could be fixed in prettify-symbols-mode instead?

@ghollisjr
Copy link
Author

ghollisjr commented Apr 27, 2022

Unfortunately not, the issue is that prettify-symbols-mode uses font-lock-mode to manage symbol substitution & highlighting, and SLIME functions didn't use the font-lock-mode setting variables which are needed because font-lock-mode essentially shadows the usual variables. The font-lock-* variables are pretty much 1-to-1 replacements and just need to be managed in parallel to guarantee interoperability with font-lock-mode-based modes.

So I added those variables to the SLIME functions and now SLIME works with or without prettify-symbols-mode/font-lock-mode.

I mentioned a small blemish in the REPL coloring when using prettify-symbols-mode, but that's specifically a prettify-symbols-mode issue and can't be helped from SLIME's side due to prettify-symbols-mode treating the REPL buffer as any other buffer, so output gets treated like code by the syntax coloring algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants