Comment full abort message to avoid syntax hilighting issues #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismbo
requested changes
Apr 28, 2020
|
Donezo
|
luismbo
reviewed
May 1, 2020
| @@ -580,8 +580,14 @@ joined together.")) | |||
| (slime-save-marker slime-output-start | |||
| (slime-save-marker slime-output-end | |||
| (goto-char slime-output-end) | |||
| (insert-before-markers (format "; Evaluation aborted on %s.\n" | |||
| condition)) | |||
| (let ((abort-msg-start (point)) | |||
There was a problem hiding this comment.
(insert-before-markers (format "; Evaluation aborted on %s.\n"
(replace-regexp-in-string "\n" "\n;" condition)))🤔 This seems a bit complicated. How about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first line of error messages is printed with a leading semi-colon. The remaining lines, however, are not and as such syntax highlighting can be messed up by a quote. See the screenshot:
After this change:
