Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#379 Remove bindings on SPC #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue#379 Remove bindings on SPC #383

wants to merge 1 commit into from

Conversation

psequeirag
Copy link

The explicit bindings on SPC are not strictly necessary in order to
display the arglist in the echo area thanks to the hook registered
with eldoc. Furthermore, these bindings may conflict with other modes
like parinfer, which relies on SPC being a self-insert-command to work
properly, and so these bindings are dropped.

Notes

  • I didn't succeed in my first attempt to run the tests with make check, so I haven't yet verified that I'm not breaking anything.
  • I'm not sure if the slime-space could also be dropped because it's referenced in a line like this:
    (put 'slime-space 'delete-selection t) ; for delete-section-mode & CUA

The explict bindings on SPC are not strictly necessary in order to
display the arglist in the echo area thanks to the hook registered
with eldoc. Furthermore, these bindings may conflict with other modes
like parinfer, which relies on SPC being a self-insert-command to work
properly.
@luismbo
Copy link
Member

luismbo commented Apr 22, 2017

With your changes, the documentation is no longer fontified (i.e., no pretty colors). (I'm using Emacs 25.1, FWIW.)

@psequeirag
Copy link
Author

Hmm, I had been testing only with slime-autodoc enabled, and the arglist still shows fontified with it:
slime-space-autodoc

If I don't load slime-autodoc, I don't even see an argslist at all in the echo area, even with an open connection to sbcl. I'm not sure if this is the same you see. Here are my settings in .emacs.d/init.el:

(add-to-list 'load-path "~/projects/slime")
(require 'slime-autoloads)
(setq inferior-lisp-program "~/Downloads/sbcl/run-sbcl.sh")
(add-to-list 'slime-contribs 'slime-fancy)

@psequeirag
Copy link
Author

Also forgot to mention that I'm testing this with Emacs 24, I'll need to setup a 25 and retry.

In any case, the changes do disable displaying the arglist upon pressing SPC unless slime-autodoc is enabled. If you did not want that, then I'll have to try parinfer's approach of registering with post-command-hook.

@ioannad
Copy link
Member

ioannad commented May 16, 2017

Refers to Issue #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants