Bug with subscription documents
#84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
subscriptionquery results in an errorTypeError: Cannot read properties of undefined (reading 'name'), originating here: https://github.com/slicknode/graphql-query-complexity/blob/master/src/QueryComplexity.ts#L260.I am not sure if this is only failing because the server isn't configured handle subscriptions.
This bug is preventing GraphQL from being able to reply with "Schema is not configured to execute subscription operation.".
This PR adds a test case demonstrating the issue. I haven't time to look into it any further.