port to gtk4 #561
Draft
port to gtk4 #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gtk.main() and Gtk.main_quit() are dropped in gtk4 in favor of subclassing Gtk.Application. This commit also moves argument handling from a separate thread to GtkApplication.do_startup().
Open
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #560, will rebase the first two commits away once that is merged.
Needs #558 for the trayicon - with the trayicon plugin disabled, this can be tested as-is.
The changes in the .glade xml files are rather noisy, they were partially done using gtk-builder-tool.
I mostly made sure that things still looked correct visually after running the tool.
Opening this as draft for now, as it relies on the two PRs above. Additionally, this is a rather big PR, and I'd like to split it into things that are backwards compatible with gtk3 (like most changes in the .glade files) and things that are not.
It also likely needs some changes in the configurations/dependencies.
Fixes #367.
Fixes #521.
Fixes #473.