Display error message if config.local.php is not writable

slawkens · Feb 4, 2024 · 647eae0 · 647eae0
1 parent e2487f9
commit 647eae0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/system/settings.php b/system/settings.php
@@ -1651,7 +1651,12 @@
 				}
 			}
 
-			return Settings::saveConfig($configToSave, BASE . 'config.local.php');
+			$success = Settings::saveConfig($configToSave, BASE . 'config.local.php');
+			if (!$success) {
+				error('There has been error saving the config.local.php - probably problem with permissions.');
+			}
+
+			return $success;
 		},
 	],
 ];

diff --git a/system/src/Settings.php b/system/src/Settings.php
@@ -557,10 +557,10 @@ public static function saveConfig($config, $filename, &$content = '')
 			$content .= ';' . PHP_EOL;
 		}
 
-		$success = file_put_contents($filename, $content);
+		$success = @file_put_contents($filename, $content);
 
 		// we saved new config.php, need to revalidate cache (only if opcache is enabled)
-		if (function_exists('opcache_invalidate')) {
+		if ($success && function_exists('opcache_invalidate')) {
 			opcache_invalidate($filename);
 		}
 
@@ -606,7 +606,7 @@ public static function testDatabaseConnection($config): bool
 		return true;
 	}
 
-	public function getErrors() {
+	public function getErrors(): array {
 		return $this->errors;
 	}