Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle incorrectly set language parameter #1756

Merged
merged 2 commits into from Feb 7, 2024
Merged

Handle incorrectly set language parameter #1756

merged 2 commits into from Feb 7, 2024

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Jul 14, 2023 •
edited

If the query parameter was set to a language not actually present in the document, no language was selected.

@realityking
Copy link
Contributor Author

realityking commented Jul 14, 2023 •
edited

Originally this PR had an additional commit to always generate URLs using language=. I realised this is actually not a bug but that slate is written in a way that both ?ruby and ?language=ruby are supported. IMHO that's a rather odd decision but since it's not a bug I've removed the commit from this PR.

@realityking realityking changed the title Fix two bugs around language handling Handle incorrectly set language parameter Jul 14, 2023
MasterOdin
MasterOdin approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Made a slight tweak to use native JS feature, as Array.includes has been supported in browsers for ~9 years that I think safe to incorporate using it in slate.

@MasterOdin MasterOdin merged commit 50239a7 into slatedocs:main Feb 7, 2024
0 of 5 checks passed
@realityking realityking deleted the lang-fixes branch April 11, 2024 15:48
EmberCraze pushed a commit to gigapay/Documentation that referenced this pull request Apr 30, 2024
@realityking @MasterOdin @EmberCraze
Handle incorrectly set language parameter (slatedocs#1756)
9449d21 
Co-authored-by: Matthew Peveler <matt.peveler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@realityking @MasterOdin