Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Swift protobuf code for logging support #100

Merged
merged 3 commits into from Mar 13, 2024

Conversation

Joannis
Copy link
Contributor

@Joannis Joannis commented Mar 9, 2024

No description provided.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (90d4693) to head (9b7c137).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files          65       65           
  Lines        1925     1925           
=======================================
  Hits         1905     1905           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@slashmo slashmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Joannis! I look forward to also getting Logging support into Swift OTel 🥳

Tests/OTLPGRPCTests/OTLPGRPCMockCollector.swift Outdated Show resolved Hide resolved
@slashmo slashmo enabled auto-merge (squash) March 13, 2024 06:43
@slashmo slashmo merged commit a2fa434 into slashmo:main Mar 13, 2024
8 checks passed
@Joannis Joannis deleted the jo/add-logs-protobuf branch March 13, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants