New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to netcore rtm #1
upgrade to netcore rtm #1
Conversation
added change with updated xproj project files. VS will now use atrifacts folder as build-base-path. |
Open question: |
As you said we have our slambybase image, but not pushed the Dockerfile for that yet. We will do it and also push it to Docker Hub. |
…c with cli. can be reverted once msbuild tooling goes live
well, i have to admit that i had hard times dealing with some issues i encountered.
and some other smaller changes... anyway, the app is up and running. to test you can use the following dockerfile don't forget to build the image against the published folder, not the source. |
to keep dotnet cli and vs in sync i changed the output directories back to the default, instead of artifacts folder. as msbuild tooling support is coming quickly, this can be done more easily soon. |
ok this pr is definitely getting longer and longer... 😳 😱 👷
Finally some good news: the API was tested with slamby-insight electron, and it seems it works without any issue. |
manually merged into 'master' branch |
I'm proudly presenting the very first PR ✨ ⭐
Changes:
As there were some breaking changes between the versions, I had to change some implementation details:
Currently all the tests are green, though the application was not tested at all. Please review my changes, and feel free to comment.
Cheers! ✌️