Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to netcore rtm #1

Merged
merged 18 commits into from Nov 4, 2016

Conversation

attilaersek
Copy link
Contributor

@attilaersek attilaersek commented Oct 26, 2016

I'm proudly presenting the very first PR ✨ ⭐

Changes:

  • updated projects to .net core 1.0.0 rtm with tooling preview 2

As there were some breaking changes between the versions, I had to change some implementation details:

  • in Slamby.Common.DI namespace the Scanner and IServiceCollectionExtensions classes are changed
  • in Slamby.API.Helpers.Swashbuckle namespace I had to add the missing annotation attributes.
  • the Slamby.API.Helpers.Swashbuckle.RegexModelFilter class renamed to RegexSchemaFilter and now it implements ISchemaFilter
  • some other smaller changes

Currently all the tests are green, though the application was not tested at all. Please review my changes, and feel free to comment.

Cheers! ✌️

@attilaersek
Copy link
Contributor Author

added change with updated xproj project files. VS will now use atrifacts folder as build-base-path.

@attilaersek
Copy link
Contributor Author

Open question:
As the solution relies on your own docker image, it should be updated as well. Should i update the project with docker tools support and change the Dockerfile and compose.yml to use microsoft/dotnet:latest as base image? It will definitely has some advantages (VS debugging exeprience with docker) and drawbacks (more complicated dockerfile).

@attilalaszlo
Copy link

As you said we have our slambybase image, but not pushed the Dockerfile for that yet. We will do it and also push it to Docker Hub.
In that image we have already restored the most of the packages so the build process can be 5-6 minutes.
I think we should do that for this change also.

@attilaersek
Copy link
Contributor Author

attilaersek commented Oct 28, 2016

well, i have to admit that i had hard times dealing with some issues i encountered.

  • on ubuntu Socket.Connect throws PlatformNotSupportedException (see dotnet/corefx#8768. As a workaround I resolve redis hostnames manually.
  • on ubuntu .netcore.app:1.0.1 fail to load native.ssl dependencies. as it's fixed in 1.1.0 i've upgraded to 1.1.0-preview-*. for details check dotnet/corefx#13060
  • had to fix aspnet/Hosting#793

and some other smaller changes...

anyway, the app is up and running. to test you can use the following dockerfile
FROM microsoft/aspnetcore:1.1.0-preview1
ARG source=.
WORKDIR /app
EXPOSE 80
COPY $source .
ENTRYPOINT ["dotnet", "Slamby.API.dll"]

don't forget to build the image against the published folder, not the source.

@attilaersek
Copy link
Contributor Author

to keep dotnet cli and vs in sync i changed the output directories back to the default, instead of artifacts folder. as msbuild tooling support is coming quickly, this can be done more easily soon.

@attilaersek
Copy link
Contributor Author

ok this pr is definitely getting longer and longer... 😳 😱 👷

  • in previous milestones, MVC's JSON serialization used Json.NET's default naming convention (pascal casing), in 1.0.0, MVC uses camel case names by default. see: aspnet/Mvc#4842. i added a workaround to fix this.
  • i updated some of the packages to the stable versions
  • the class libraries are retargeted to netstandard1.6 to improve package reuseability. though I had to import "portable-net45+win8" to be able to reference Slamby.SDK.Net. (updating that package is out of scope)

Finally some good news: the API was tested with slamby-insight electron, and it seems it works without any issue.
👏

@illeszsolt illeszsolt merged commit f683782 into slamby:master Nov 4, 2016
@illeszsolt
Copy link

manually merged into 'master' branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants