Update codeowners to support new config format #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code handled the following: paths: - my/path/one - my/path/two This code now handles this version: paths: - path: my/path/one - path: my/path/two Next need to handle both variations like so: paths: - path: my/path/one - my/path/two Prob need a custom deserializer or something like that.
This is a much better solution as it handles the additional "notify" as well. Tests have also been updated. The problem is this does not yet handle the variation of: paths: - path: my/path - my/other path This is still WIP.
This now supports both types of "path". I'll look at splitting up the code into separate files for clarity. Not 100% sure this is the best way to do this, but looking forward to comments during review.
jhperezd
requested review from
linhpha and
ryan-moore-slack
and removed request for
ryan-moore-slack and
linhpha
linhpha
approved these changes
May 21, 2024
ryan-moore-slack
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathobjects for the config are changing, this PR introduces support for the new format.Currently
pathslooks as follows:We are adding a new
notifyflag which means that apathcan be either a string (i.e. previous format) or an object (new format:This PR introduces a custom deserializer and a Path object to be able to handle the above. The changes are backwards compatible so old configs will still work as usual.
Testing: