disk based chunk rollover should also have a time based limit #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlb
requested changes
May 7, 2024
astra/src/main/java/com/slack/astra/chunkrollover/DiskOrMessageCountBasedRolloverStrategy.java
Show resolved
Hide resolved
vthacker
force-pushed
the
time_based_rollover
branch
3 times, most recently
from
6bfd66d
to
970497c
Compare
bryanlb
previously approved these changes
May 8, 2024
vthacker
force-pushed
the
time_based_rollover
branch
from
970497c
to
0929dfe
Compare
bryanlb
requested changes
May 8, 2024
astra/src/main/java/com/slack/astra/chunkrollover/DiskOrMessageCountBasedRolloverStrategy.java
Outdated
Show resolved
Hide resolved
vthacker
force-pushed
the
time_based_rollover
branch
from
0929dfe
to
235fda1
Compare
bryanlb
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is especially useful in dev where the log volume is low to have a time based rollover on top of disk size.
We see scenarios where a chunk is several hours long and during an indexer deploy messages are missing till the recovery task completes.
In a separate task we should try to write out the current chunk during an indexer deploy