Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Expose team_id parameter for use with org-wide app #1283

Merged
merged 12 commits into from May 16, 2024

Conversation

candiduslynx
Copy link
Contributor

Fixes #1282

@candiduslynx
Copy link
Contributor Author

Hi @parsley42!

I've noticed that you reviewed several PRs before, so tagging you here.

This PR mainly goes through the list mentioned in the issue & adds team_id param setting.

@parsley42
Copy link
Member

Hi @candiduslynx - I'm retiring from being the de facto maintainer of this project; slack-go/slack needs maintainers, please email me at the address on my GitHub page if interested, thanks.

Copy link
Contributor Author

@candiduslynx candiduslynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parsley42 the tests have passed, so I'd like another set of eyes to merge this

@parsley42 parsley42 self-requested a review May 15, 2024 12:38
Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be interested in your thinking on updating the version, but otherwise this looks reasonable to me.

bots.go Show resolved Hide resolved
Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@candiduslynx candiduslynx merged commit 41fa1e5 into slack-go:master May 16, 2024
4 checks passed
@candiduslynx candiduslynx deleted the fix/expose-team_id-param branch May 16, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Missing team_id param
2 participants