Fix resource issues #1812
Merged
Fix resource issues #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylot
approved these changes
Apr 8, 2023
|
@nitram84 thanks for fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested recompiling with some random simple apps, e.g.
https://apkpure.com/typescript-tutorial/com.cosmiclearn.typescripttutorial
https://apkpure.com/gradle-dependencies-generator/com.androidgradle.app
and just fixed the first resource or gradle issue in each iteration. The first app now fails with a java issue. I used gradle 7.4.2 to take another bug (also reproducible with gradle 7.6).
For review: Each commit fixes one bug. I used apktool as a reference for the exported resources.
The following issues can now be closed: #1073 and #1682
For the next issues a data structure to aggregate infos for gradle build file generation would help, e.g. for a flag to track usage of "android:pathData-Attributes" + minSdkVersion < 21 to set "vectorDrawables.useSupportLibrary = true" or a legacy Apache http client detection....