Add passphrase compatibility to the hw wallet #2218

Senyoret1 · 2019-02-27T22:59:20Z

Changes:

Now it is possible to add passphrases to the hardware wallet.

This PR includes many texts, so it would be good to check them with some care, since there may be errors.

Does this change need to mentioned in CHANGELOG.md?

gz-c · 2019-03-11T03:56:15Z

Will not be merged until later; this is scheduled for v2 wallet firmware

SkycoinSynth · 2021-03-26T16:32:51Z

...omponents/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.spec.ts

+
+import { HwPassphraseDialogComponent } from './hw-passphrase-dialog.component';
+
+describe('HwPassphraseDialogComponent', () => {


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

describe('HwPassphraseDialogComponent', () => {

describe("HwPassphraseDialogComponent", () => {

SkycoinSynth · 2021-03-26T16:32:52Z

...ents/layout/hardware-wallet/hw-passphrase-help-dialog/hw-passphrase-help-dialog.component.ts

@@ -0,0 +1,14 @@
+import { Component } from '@angular/core';
+import { MatDialogRef } from '@angular/material/dialog';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { MatDialogRef } from '@angular/material/dialog';

import { MatDialogRef } from "@angular/material/dialog";

SkycoinSynth · 2021-03-26T16:32:53Z

...ents/layout/hardware-wallet/hw-passphrase-help-dialog/hw-passphrase-help-dialog.component.ts

+
+@Component({
+  selector: 'app-hw-passphrase-help-dialog',
+  templateUrl: './hw-passphrase-help-dialog.component.html',


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

templateUrl: './hw-passphrase-help-dialog.component.html',

templateUrl: "./hw-passphrase-help-dialog.component.html",

SkycoinSynth · 2021-03-26T16:32:54Z

...ents/layout/hardware-wallet/hw-passphrase-help-dialog/hw-passphrase-help-dialog.component.ts

+import { MatDialogRef } from '@angular/material/dialog';
+
+@Component({
+  selector: 'app-hw-passphrase-help-dialog',


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

selector: 'app-hw-passphrase-help-dialog',

selector: "app-hw-passphrase-help-dialog",

SkycoinSynth · 2021-03-26T16:32:55Z

...c/src/app/components/layout/hardware-wallet/hw-options-dialog/hw-options-dialog.component.ts

@@ -12,6 +12,7 @@ import { HwChangePinDialogComponent } from '../hw-change-pin-dialog/hw-change-pi
 import { HwRestoreSeedDialogComponent } from '../hw-restore-seed-dialog/hw-restore-seed-dialog.component';
 import { Observable } from 'rxjs/Observable';
 import { HwDialogBaseComponent } from '../hw-dialog-base.component';
+import { HwPassphraseActivationDialogComponent } from '../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { HwPassphraseActivationDialogComponent } from '../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component';

import { HwPassphraseActivationDialogComponent } from "../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component";

SkycoinSynth · 2021-03-26T16:32:56Z

...hardware-wallet/hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component.ts

+import { HwWalletService, OperationResults } from '../../../../services/hw-wallet.service';
+import { ChildHwDialogParams } from '../hw-options-dialog/hw-options-dialog.component';
+import { HwDialogBaseComponent } from '../hw-dialog-base.component';
+import { HwPassphraseHelpDialogComponent } from '../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { HwPassphraseHelpDialogComponent } from '../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component';

import { HwPassphraseHelpDialogComponent } from "../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component";

SkycoinSynth · 2021-03-26T16:32:57Z

...are-wallet/hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component.spec.ts

+
+import { HwPassphraseActivationDialogComponent } from './hw-passphrase-activation-dialog.component';
+
+describe('HwPassphraseActivationDialogComponent', () => {


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

describe('HwPassphraseActivationDialogComponent', () => {

describe("HwPassphraseActivationDialogComponent", () => {

SkycoinSynth · 2021-03-26T16:32:58Z

...hardware-wallet/hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component.ts

+import { MatDialogRef, MAT_DIALOG_DATA, MatDialog, MatDialogConfig } from '@angular/material/dialog';
+import { HwWalletService, OperationResults } from '../../../../services/hw-wallet.service';
+import { ChildHwDialogParams } from '../hw-options-dialog/hw-options-dialog.component';
+import { HwDialogBaseComponent } from '../hw-dialog-base.component';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { HwDialogBaseComponent } from '../hw-dialog-base.component';

import { HwDialogBaseComponent } from "../hw-dialog-base.component";

SkycoinSynth · 2021-03-26T16:32:59Z

electron/src/hardware-wallet.js

+
+    console.log("Hardware wallet passphrase requested");
+    if (win) {
+      win.webContents.send('hwPassphraseRequested');


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

win.webContents.send('hwPassphraseRequested');

win.webContents.send("hwPassphraseRequested");

SkycoinSynth · 2021-03-26T16:33:00Z

...hardware-wallet/hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component.ts

@@ -0,0 +1,60 @@
+import { Component, Inject } from '@angular/core';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { Component, Inject } from '@angular/core';

import { Component, Inject } from "@angular/core";

SkycoinSynth · 2021-03-26T16:33:01Z

...are-wallet/hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component.spec.ts

+    fixture.detectChanges();
+  });
+
+  it('should be created', () => {


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

it('should be created', () => {

it("should be created", () => {

SkycoinSynth · 2021-03-26T16:33:02Z

...omponents/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.spec.ts

@@ -0,0 +1,25 @@
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { async, ComponentFixture, TestBed } from '@angular/core/testing';

import { async, ComponentFixture, TestBed } from "@angular/core/testing";

SkycoinSynth · 2021-03-26T16:33:04Z

...app/components/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.ts

@@ -0,0 +1,44 @@
+import { Component, OnInit, OnDestroy } from '@angular/core';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { Component, OnInit, OnDestroy } from '@angular/core';

import { Component, OnInit, OnDestroy } from "@angular/core";

SkycoinSynth · 2021-03-26T16:33:05Z

...app/components/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.ts

+
+@Component({
+  selector: 'app-hw-passphrase-dialog',
+  templateUrl: './hw-passphrase-dialog.component.html',


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

templateUrl: './hw-passphrase-dialog.component.html',

templateUrl: "./hw-passphrase-dialog.component.html",

SkycoinSynth · 2021-03-26T16:33:06Z

...app/components/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.ts

+@Component({
+  selector: 'app-hw-passphrase-dialog',
+  templateUrl: './hw-passphrase-dialog.component.html',
+  styleUrls: ['./hw-passphrase-dialog.component.scss'],


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

styleUrls: ['./hw-passphrase-dialog.component.scss'],

styleUrls: ["./hw-passphrase-dialog.component.scss"],

SkycoinSynth · 2021-03-26T16:33:07Z

...app/components/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.ts

@@ -0,0 +1,44 @@
+import { Component, OnInit, OnDestroy } from '@angular/core';
+import { FormBuilder, Validators, FormGroup } from '@angular/forms';
+import { MatDialogRef, MatDialog, MatDialogConfig } from '@angular/material/dialog';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { MatDialogRef, MatDialog, MatDialogConfig } from '@angular/material/dialog';

import { MatDialogRef, MatDialog, MatDialogConfig } from "@angular/material/dialog";

SkycoinSynth · 2021-03-26T16:33:08Z

...layout/hardware-wallet/hw-passphrase-help-dialog/hw-passphrase-help-dialog.component.spec.ts

+    fixture.detectChanges();
+  });
+
+  it('should be created', () => {


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

it('should be created', () => {

it("should be created", () => {

SkycoinSynth · 2021-03-26T16:33:09Z

...hardware-wallet/hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component.ts

+}
+
+@Component({
+  selector: 'app-hw-passphrase-activation-dialog',


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

selector: 'app-hw-passphrase-activation-dialog',

selector: "app-hw-passphrase-activation-dialog",

SkycoinSynth · 2021-03-26T16:33:10Z

...tatic/src/app/components/layout/hardware-wallet/hw-added-dialog/hw-added-dialog.component.ts

+
+  openHelp() {
+    this.dialog.open(HwPassphraseHelpDialogComponent, <MatDialogConfig> {
+      width: '450px',


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

width: '450px',

width: "450px",

SkycoinSynth · 2021-03-26T16:33:11Z

...app/components/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.ts

@@ -0,0 +1,44 @@
+import { Component, OnInit, OnDestroy } from '@angular/core';
+import { FormBuilder, Validators, FormGroup } from '@angular/forms';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { FormBuilder, Validators, FormGroup } from '@angular/forms';

import { FormBuilder, Validators, FormGroup } from "@angular/forms";

SkycoinSynth · 2021-03-26T16:33:12Z

...app/components/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.ts

+import { Component, OnInit, OnDestroy } from '@angular/core';
+import { FormBuilder, Validators, FormGroup } from '@angular/forms';
+import { MatDialogRef, MatDialog, MatDialogConfig } from '@angular/material/dialog';
+import { HwWalletService } from '../../../../services/hw-wallet.service';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import { HwWalletService } from '../../../../services/hw-wallet.service';

import { HwWalletService } from "../../../../services/hw-wallet.service";

SkycoinSynth · 2021-03-26T16:33:13Z

...app/components/layout/hardware-wallet/hw-passphrase-dialog/hw-passphrase-dialog.component.ts

+
+  ngOnInit() {
+    this.form = this.formBuilder.group({
+      passphrase: ['', Validators.required],


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

passphrase: ['', Validators.required],

passphrase: ["", Validators.required],

mahansky

.

Add passphrase compatibility

be9ec71

gz-c requested a review from mahansky March 7, 2019 09:06

gz-c changed the title ~~Add passphrase compatibility~~ Add passphrase compatibility to the hw wallet Jun 24, 2019

SkycoinSynth reviewed Mar 26, 2021

View reviewed changes

mahansky reviewed Jun 8, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add passphrase compatibility to the hw wallet #2218

Add passphrase compatibility to the hw wallet #2218

Senyoret1 commented Feb 27, 2019

gz-c commented Mar 11, 2019

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

SkycoinSynth Mar 26, 2021

mahansky left a comment


		import { HwPassphraseDialogComponent } from './hw-passphrase-dialog.component';

		describe('HwPassphraseDialogComponent', () => {

	describe('HwPassphraseDialogComponent', () => {
	describe("HwPassphraseDialogComponent", () => {

		@@ -0,0 +1,14 @@
		import { Component } from '@angular/core';
		import { MatDialogRef } from '@angular/material/dialog';

	import { MatDialogRef } from '@angular/material/dialog';
	import { MatDialogRef } from "@angular/material/dialog";

	templateUrl: './hw-passphrase-help-dialog.component.html',
	templateUrl: "./hw-passphrase-help-dialog.component.html",

	selector: 'app-hw-passphrase-help-dialog',
	selector: "app-hw-passphrase-help-dialog",

	import { HwPassphraseActivationDialogComponent } from '../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component';
	import { HwPassphraseActivationDialogComponent } from "../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component";

	import { HwPassphraseHelpDialogComponent } from '../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component';
	import { HwPassphraseHelpDialogComponent } from "../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component";


		import { HwPassphraseActivationDialogComponent } from './hw-passphrase-activation-dialog.component';

		describe('HwPassphraseActivationDialogComponent', () => {

	describe('HwPassphraseActivationDialogComponent', () => {
	describe("HwPassphraseActivationDialogComponent", () => {

	import { HwDialogBaseComponent } from '../hw-dialog-base.component';
	import { HwDialogBaseComponent } from "../hw-dialog-base.component";

	win.webContents.send('hwPassphraseRequested');
	win.webContents.send("hwPassphraseRequested");

		@@ -0,0 +1,60 @@
		import { Component, Inject } from '@angular/core';

	import { Component, Inject } from '@angular/core';
	import { Component, Inject } from "@angular/core";

	it('should be created', () => {
	it("should be created", () => {

		@@ -0,0 +1,25 @@
		import { async, ComponentFixture, TestBed } from '@angular/core/testing';

		@@ -0,0 +1,44 @@
		import { Component, OnInit, OnDestroy } from '@angular/core';

	templateUrl: './hw-passphrase-dialog.component.html',
	templateUrl: "./hw-passphrase-dialog.component.html",

	styleUrls: ['./hw-passphrase-dialog.component.scss'],
	styleUrls: ["./hw-passphrase-dialog.component.scss"],

	import { MatDialogRef, MatDialog, MatDialogConfig } from '@angular/material/dialog';
	import { MatDialogRef, MatDialog, MatDialogConfig } from "@angular/material/dialog";

Add passphrase compatibility to the hw wallet #2218

Are you sure you want to change the base?

Add passphrase compatibility to the hw wallet #2218

Conversation

Senyoret1 commented Feb 27, 2019

gz-c commented Mar 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mahansky left a comment

Choose a reason for hiding this comment

	selector: 'app-hw-passphrase-activation-dialog',
	selector: "app-hw-passphrase-activation-dialog",

		@@ -0,0 +1,44 @@
		import { Component, OnInit, OnDestroy } from '@angular/core';
		import { FormBuilder, Validators, FormGroup } from '@angular/forms';

	import { HwWalletService } from '../../../../services/hw-wallet.service';
	import { HwWalletService } from "../../../../services/hw-wallet.service";

	passphrase: ['', Validators.required],
	passphrase: ["", Validators.required],