Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semi WIP] jasmine-globals: support arbitrary jasmineSpy.and.* usage #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JHilker
Copy link
Contributor

@JHilker JHilker commented Apr 4, 2019

This is a bit move involved, but it works to find any .and.* usage if the spy is defined as a variable and mutated later.

I'm going test it a bit more while adding other features, but figured I'd toss this PR up now since it should be in a pretty good state, but I could definitely foresee some edge cases given the scope of it.

Copy link
Owner

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here!

@skovhus
Copy link
Owner

skovhus commented May 27, 2019

@JHilker Sorry for me being slow at responding to your other PRs.

jest-codemods@0.20 contains a lot of your work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants