This repository has been archived by the owner on Sep 13, 2021. It is now read-only.
Fix own course and resource votes not getting shown #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`initialVote` always contained the vote, but not on first render of the component, so `useState()` returned `null` to `currentVote`, and it then just stayed like that.
ruohola
force-pushed
the
no-login-verify
branch
2 times, most recently
from
1b3e64f
to
78e948b
Compare
blomqma
previously approved these changes
Dec 18, 2020
ruohola
force-pushed
the
no-login-verify
branch
2 times, most recently
from
c5f26c7
to
f309eb3
Compare
ruohola
force-pushed
the
no-login-verify
branch
2 times, most recently
from
91b3e8f
to
a25a2d1
Compare
ruohola
commented
Dec 18, 2020
ruohola
commented
Dec 18, 2020
| RUN yarn build | ||
|
|
||
| CMD ["yarn", "start"] | ||
| # Get rid of all dev dependencies. | ||
| RUN yarn install --production --ignore-scripts --prefer-offline |
There was a problem hiding this comment.
ruohola
commented
Dec 19, 2020
Remove dev dependencies and all unnecessary stuff from the prod build. Also set the NODE_ENV env variable, which should for example should hide the 'SW Registered' console log.
ruohola
force-pushed
the
no-login-verify
branch
from
a25a2d1
to
3a8663a
Compare
blomqma
approved these changes
Dec 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/jQGgVomQ/699-course-vote-statuses-are-not-fetched-on-page-load