-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jbranchaud/egg 270 create lifetime membership checkout session #1441
Open
jbranchaud
wants to merge
12
commits into
main
Choose a base branch
from
jbranchaud/egg-270-create-lifetime-membership-checkout-session
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
jbranchaud/egg 270 create lifetime membership checkout session #1441
jbranchaud
wants to merge
12
commits into
main
from
jbranchaud/egg-270-create-lifetime-membership-checkout-session
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
make it explicit what the known/handled stripe events are
jbranchaud
force-pushed
the
jbranchaud/egg-270-create-lifetime-membership-checkout-session
branch
from
May 6, 2024 15:34
6f52fdd
to
e751192
Compare
the server needs this value (not the checkout session ID) in order to create a `transaction` record for this purchase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two core things:
First, it sets up the pre-purchase flow for Lifetime Subscriptions via the
/forever
path. This collects an email if the user is not already signed in and then hands them off to a Stripe checkout session.Second, it handles the post-purchase flow. This sets up egghead-next to process Stripe webhook events for
checkout.session.completed
via inngest. It will only process for a specific purchase (stripe price ID) because everything else should be handled by the egghead-rails backend.Note: this depends on some API changes being merged into egghead-rails before this changes can be deployed.
Deployment Task
checkout.session.completed
to the list of events for the production webhook endpoint