Implement Jitter #81
Open
Implement Jitter #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas131
force-pushed
the
master
branch
2 times, most recently
from
3e77675
to
0c0aa04
Compare
cgzones
reviewed
Mar 10, 2022
endlessh.c
Outdated
| @@ -105,6 +106,12 @@ logsyslog(enum loglevel level, const char *format, ...) | |||
| } | |||
| } | |||
|
|
|||
| static long long random_delay(int delay, float jitter) { | |||
| long long tmp = delay*jitter; | |||
| tmp = delay+(rand()%(2*tmp))-tmp; //insecure rand() was used on purpose to avoid potential performance bottleneck | |||
There was a problem hiding this comment.
This depends on undefined behavior if jitter is 0.
Maybe add something like
if (jitter <= 0)
return delay;
endlessh.c
Outdated
| { | ||
| errno = 0; | ||
| char *end; | ||
| float tmp = strtof(s, &end); |
There was a problem hiding this comment.
Why parse as float? Are per mille values useful?
endlessh.c
Outdated
| errno = 0; | ||
| char *end; | ||
| float tmp = strtof(s, &end); | ||
| if (errno || *end) { //TODO: additional checks? |
There was a problem hiding this comment.
Maybe check for negative or too big (>100?) values?
|
Thanks for this awesome code-review @skeeto . This issues are fixed and I have also documented the feature in the Manpage. |
Thomas131
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71
In a simple test everything seemed to work well.
Documentation needs to be done, but I can't really get along with the manpage-Syntax.