Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load bookmark thumbnails after import #724

Merged
merged 4 commits into from
May 10, 2024

Conversation

vslinko
Copy link
Contributor

@vslinko vslinko commented May 9, 2024

No description provided.

@vslinko vslinko force-pushed the update-preview-after-import branch 2 times, most recently from 19e95a2 to 8751665 Compare May 9, 2024 08:35
@vslinko vslinko force-pushed the update-preview-after-import branch 3 times, most recently from b62d335 to 8851b13 Compare May 9, 2024 12:21
@vslinko vslinko changed the title Update thumbnails after import Update thumbnails after import + Safer way to download thumbnails May 9, 2024
@vslinko
Copy link
Contributor Author

vslinko commented May 9, 2024

it's ready to merge

bookmarks/services/preview_image_loader.py Outdated Show resolved Hide resolved
bookmarks/tests/test_website_loader.py Outdated Show resolved Hide resolved
bookmarks/services/preview_image_loader.py Show resolved Hide resolved
@vslinko vslinko force-pushed the update-preview-after-import branch from 8851b13 to 0f8ac5b Compare May 9, 2024 20:56
@vslinko vslinko force-pushed the update-preview-after-import branch from 0f8ac5b to b8db53e Compare May 9, 2024 20:59
@vslinko
Copy link
Contributor Author

vslinko commented May 9, 2024

@sissbruecker fixed all your comments, could you please check again

@sissbruecker sissbruecker changed the title Update thumbnails after import + Safer way to download thumbnails Load bookmark thumbnails after import May 10, 2024
@sissbruecker
Copy link
Owner

Thanks again!

@sissbruecker sissbruecker merged commit b4376a9 into sissbruecker:master May 10, 2024
2 checks passed
@sissbruecker
Copy link
Owner

Also added this: #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants