Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for marking bookmarks as unread by default #706

Merged
merged 3 commits into from Apr 17, 2024

Conversation

ab623
Copy link
Contributor

@ab623 ab623 commented Apr 17, 2024

Fixes #669

This feature adds an option to the user profile to set the default state for Mark as unread.

  • The migration does not update the current default, therefore there is no migration impact.
  • I chose to make the field Mark as unread default, rather than a Mark as read default, this is so that it mirror the existing form. e.g if its checked in the setting it will be checked on the bookmarks form.

This is my first proper contribution to this project, so apologies if I have missed anything. I picked up this feature as it seemed like an easy one to implement.

Copy link
Owner

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Could use one more test.

bookmarks/tests/test_bookmark_new_view.py Outdated Show resolved Hide resolved
@sissbruecker sissbruecker changed the title Mark as unread default state Add option for marking bookmarks as unread by default Apr 17, 2024
@sissbruecker sissbruecker merged commit 9dc3521 into sissbruecker:master Apr 17, 2024
2 checks passed
@sissbruecker
Copy link
Owner

Thanks!

@ab623 ab623 deleted the feat-mark-default-unread branch April 17, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default new links to unread?
2 participants