Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for passing arguments to single-file command #691

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Add option for passing arguments to single-file command #691

merged 6 commits into from
Apr 9, 2024

Conversation

pettijohn
Copy link
Contributor

@pettijohn pettijohn commented Apr 9, 2024 •
edited by sissbruecker

Closes #690

Needs some additional testing:

  • base.py already looks for LD_SINGLEFILE_OPTIONS and defaults to "" when null; shlex.split("") returns [], so change should work when env variable unset
  • Tested with --user-agent <foo> and it worked on reddit (see linked issue)
  • Needs testing with multiple arguments, e.g. --user-agent <foo> --block-videos=true --block-audios=true

@sissbruecker sissbruecker changed the title Add LD_SINGLEFILE_OPTIONS support Add option for passing arguments to single-file command Apr 9, 2024
@sissbruecker sissbruecker merged commit 2b342c0 into sissbruecker:master Apr 9, 2024
2 checks passed
@sissbruecker
Copy link
Owner

Seems to work fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Agent, or, Plans for LD_SINGLEFILE_OPTIONS
2 participants
@pettijohn @sissbruecker