Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed and added commands in docker files #717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FayKounara
Copy link

No description provided.

Copy link

welcome bot commented Apr 20, 2024

Thanks so much for opening this pull request and for helping to improve SirixDB 🚀

@JohannesLichtenberger
Copy link
Member

Oh, what's this about? I thought it's Keycloak updated somehow

@FayKounara
Copy link
Author

Hello! So these changes help the container keycloak to not start and exit immediately and when i altered these i was also able to build successfully the build.gradle from the folder sirix-rest-api.

@JohannesLichtenberger
Copy link
Member

The thing is that the docker compose file in the root dir should build a new image from the sources (afterwards it's pushed to docker hub for use by the rest api bundle and for everyone).

@FayKounara
Copy link
Author

FayKounara commented Apr 21, 2024

Do you mean the sirixdb/sirix image? If you mean this image i build it with a command and then i was able to use it . Also both ports (the 8080 and 9443) are accessible and then i tried the python sdk api to see if it actually works.

interval: 30s
timeout: 5s
retries: 10
server:
build: .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in, as it's automatically built after successful tests and pushed to docker hub :-)

@FayKounara
Copy link
Author

Okay so i added this command and executed it again.From the reports that are produced i see this. Package Tests Failures Ignored Duration Success rate
io.sirix.rest 66 0 0 19.163s 100%
So can you please explain what is the problem with the sirix-rest-api because i see all the containers are running smoothly. Maybe i dont understand something. Thank you and sorry for the trouble.

@JohannesLichtenberger
Copy link
Member

The docker compose file in sirix-rest-api uses the most recent version from docker hub, which is built before via the docker compose file in the root directory of the project. I'm still not really sure what's the problem you're facing. So, using the docker compose script in sirix-rest-api starts keycloak and stops it immediately?

@FayKounara
Copy link
Author

Sorry for the confusion! I saw on the issue #711 this,The container doesn't start using the newest image,and also on the issue #707 that the tests fail. I think that these changes might help with these issues.

@JohannesLichtenberger
Copy link
Member

Oh, #707 was fixed (the keycloak image only exists for quay.io). Idk what's wrong when updating Keycloak to the newest version, though. In any case, if your changes help, we could add the local build again, I guess, regarding the root docker compose file!? Otherwise it wouldn't be updated anymore (and pushed to docker hub).

@FayKounara
Copy link
Author

If my changes prove effective, I will add the local build option in the root Docker Compose file again.Thank you and sorry for the confusion!

@JohannesLichtenberger
Copy link
Member

So, you'll update the keycloak version and check?

@FayKounara
Copy link
Author

FayKounara commented Apr 21, 2024

Could you please clarify what specific steps you'd like me to take regarding the Keycloak update? Should i investigate the issue further or add the build . in the root file and check this?

@JohannesLichtenberger
Copy link
Member

You'd have to update the Keycloak version as well (also add build . again, as it's mandatory to do a local image build)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants