Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos #38

Merged
merged 2 commits into from Mar 11, 2024
Merged

Fixing typos #38

merged 2 commits into from Mar 11, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Aug 6, 2023

This PR corrects improper markdown in README.md. It also fixes a few typos and changes several links from http to https protocol.

@adrianmiu
Copy link
Contributor

Sorry for not seeing the PR sooner

@adrianmiu adrianmiu closed this Mar 10, 2024
@deining
Copy link
Contributor Author

deining commented Mar 10, 2024

Sorry for not seeing the PR sooner

No problem, but why are you closing (=rejecting) my PR without giving any reason?

@adrianmiu adrianmiu reopened this Mar 11, 2024
@adrianmiu adrianmiu merged commit 219a10e into siriusphp:master Mar 11, 2024
3 of 4 checks passed
@adrianmiu
Copy link
Contributor

@deining Since your pull-request I have changed the library (eg: use Pest instead of PHPUnit) and the PR was showing conflicts. Upon further inspection the conflicts were few and I've merged your PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants