New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias spy.reset to spy.resetHistory #1628

Closed

GCHQDeveloper500 wants to merge 1 commit into sinonjs:master from GCHQDeveloper500:master

Contributor

GCHQDeveloper500 commented Dec 8, 2017 •

edited

Purpose (TL;DR) - mandatory

As per #1446 - spy.reset aliased to spy.resetHistory.

Background (Problem in detail) - optional

N/A, original ticket explains it all.

Solution - optional

Changed name of reset to resetHistory in code and tests
Added new test to ensure alias works
Updated docs to reflect changes

How to verify - mandatory

Check out this branch
npm install
npm test

Checklist for author

npm run lint passes
References to standard library functions are cached.


          Alias spy.reset to spy.resetHistory

0b30923

GCHQDeveloper500 closed this

Member

mroderick commented Dec 10, 2017

Did you close this by accident?

Member

mroderick commented Dec 10, 2017

I now see that you created #1630 instead. All is well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment