Remove IE specific hacks #477
Conversation
We no longer support Internet Explorer.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 95.80% 96.47% +0.66%
==========================================
Files 2 2
Lines 691 680 -11
==========================================
- Hits 662 656 -6
+ Misses 29 24 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| // setImmediate is not a standard function | ||
| // avoid adding the prop to the window object if not present | ||
| if (setImmediatePresent) { | ||
| _global.setImmediate = _global.setImmediate; |
There was a problem hiding this comment.
Node actually has setImmediate as well
There was a problem hiding this comment.
Yes, not removing that. Just the IE (IE 8 and below) specific x=x hack/workaround to make the prop writable. See https://www.adequatelygood.com/Replacing-setTimeout-Globally.html
setImmediate is still added to the timers way below (line 1032)
Purpose (TL;DR) - mandatory
We no longer support Internet Explorer, so remove those hacks.