Skip to content

Commit

Permalink
Node 14 has reached End of Life
Browse files Browse the repository at this point in the history 
Node 16 will reach EoL in one month (Sept 11 2023)
  • Loading branch information
@fatso83
fatso83 committed Aug 2, 2023
1 parent 5bdc77c commit 0719006
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:

strategy:
matrix:
node-version: [14, 16, 18, 19]
node-version: [16, 18, 19]

steps:
- uses: actions/checkout@v3
Expand Down

6 comments on commit 0719006

@SimenB
Copy link
Member

@SimenB SimenB commented on 0719006 Aug 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this is still a breaking change, even though the node versions are EOL

@fatso83
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Crap. Did not consider that for real.

@fatso83
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sufficient to just release v12 with a note or do you think we need to deprecate v11.1.0?

@SimenB
Copy link
Member

@SimenB SimenB commented on 0719006 Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest hasn't upgraded to v11, so doesn't impact "me" directly.

I'd say just re-add v14 to the testing array, then bundle dropping it (and possibly 16?) when there are actual breaking changes? Unless testing on Node 14 prevents us from making changes or updating deps it doesn't hurt being there.

@fatso83
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle dropping it (and possibly 16?)

Not sure what bundle dropping is TBH ... but I can just add a patch release for 11.*. Least amount of fuzz.

Its' a bit hard to remember to do the "... and now, just before a major, remember to commit these final changes that's not mentioned in the readme, as well", but you are absolutely right it does not hurt. It's usually worse to add newer versions of Node 😄 I just wanted to align with our list of supported environments, sooner rather than later. No rush, of course.

@SimenB
Copy link
Member

@SimenB SimenB commented on 0719006 Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what bundle dropping is TBH

What I meant is just to wait with making this change until there are other breaking changes we wanna do, then release a single major version with all of them.

If you wanna have some sort of "land these when we're making breaking changes", I've personally had good experiences with creating PRs, then adding them to a milestone. E.g. https://github.com/jestjs/jest/milestone/15

Please sign in to comment.