Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Makefile to build and push to ECR #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ltagliamonte
Copy link

simple Makefile to simplify the build and push to AWS ECR repo.
Would love to see an official build in docker repo.

@sinkingpoint
Copy link
Owner

I'd rather not have the ECR stuff by default - will work on a docker hub build today, but ECR is org specific enough that I'd rather leave that up to consumers of the repo rather than including it by default

@ltagliamonte
Copy link
Author

Sure it is just an helper other contribution could add other docker repositories

@sinkingpoint
Copy link
Owner

My point is that we don't want to be managing the code for each and every custom repository that people want to push to - that is out of the scope of this - the ECR stuff can exist outside this repo, it doesn't belong here

@ltagliamonte
Copy link
Author

@sinkingpoint any update on the official docker hub image?

@sinkingpoint
Copy link
Owner

Yep - apologies for the delay. https://hub.docker.com/r/sinkingpoint/prometheus-gravel-gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants