Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not change instance name #216

Merged
merged 4 commits into from Dec 12, 2023
Merged

Conversation

EricDeveaud
Copy link
Contributor

singularity-cli change provided instance name when it contains a dash to name with underscore.

dash is legit in instance name (see: authorizedChars regexp in https://github.com/sylabs/singularity/blob/main/internal/pkg/instance/instance_linux.go#L69)

so do not change the name and delegate instance name validation to singularity.

regards

Eric

@vsoch
Copy link
Member

vsoch commented Dec 12, 2023

This looks good! Could you please bump the version in version.py and add a corresponding note to the CHANGELOG.md?

@vsoch
Copy link
Member

vsoch commented Dec 12, 2023

Formatting failed - you will want to create a local python environment, install development requirements, and run pre-commit.

pip install -r .github/dev-requirements.txt
pre-commit run --all-files

@EricDeveaud
Copy link
Contributor Author

OK will try that

@EricDeveaud
Copy link
Contributor Author

LMK if it's OK now.

Eric

@vsoch vsoch merged commit c207c3e into singularityhub:master Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants