Automatically change Pages and Registry URL in gh-pages branch #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Update to programatically change baseurl
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
vsoch
reviewed
Apr 2, 2023
|
|
||
| - name: Set Pages base URL and Registry URL | ||
| run: | | ||
| URL=$(curl -L \ |
There was a problem hiding this comment.
I think there is some risk here of running this regularly (and having the API response not return successfully, etc.) I want to suggest we add this instruction to the tutorial, to be done once, and it's OK if it's automated like this, or just a manual instruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #100 and automatically updates the baseurl to the github pages url in the github workflow. This fixes an issue where the stylesheets were not loaded correctly due to a different baseurl.
It was possible to fix this manually, but this solution pulls the github pages URL automatically and replaces it in the config file.
In addition, this PR also automatically swaps the registry URL to the current repository in the
gh-pagesbranch. Again, this was previously a manual step.Tested in my separate repo georgiastuart/resistry-test (yes there is a typo ;) ) with pages URL here.