SimplePie: Prepare PubSubHubbub for PSR-18 clients #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
commented
May 31, 2023
| @@ -127,6 +127,20 @@ public function has_header(string $name): bool; | |||
| */ | |||
| public function get_header(string $name): array; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Again, not sure if we should duplicate the comments, rather than using {@inheritdoc}
Art4
approved these changes
Sep 13, 2023
|
@mblaney Are there any objections? |
|
I will try to get back to SimplePie development on weekend. |
no this looks good to me 👍 |
This is similar to `Psr\Http\Message\MessageInterface::withHeader()` but does not preserve the casing of the header. It will be useful for storing metadata (e.g. WebSub link) in the response.
Previously, this only supported `File`, let’s prepare for other `Response` implementations. Also fixes a bug where it would clear previous links (by setting it to comma instead of appending). And where it would add redundant `rel=self` link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this only supported
File, let’s prepare for otherResponseimplementations.Also fixes a bug where it would clear previous links (by setting it to comma instead of appending).
And where it would add redundant
rel=selflink.