Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alias-used-on): Add websites where an alias is used ✨ #1708

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mlec1
Copy link
Contributor

@mlec1 mlec1 commented Apr 26, 2023

This MR try to address the following this feature request #469

The JavaScript part may be a bit tricky, but I tried to adapt in order to keep the already existing package (here the multi-select one). I think the consistency might be better in terms of UI.

If you find a cleaner way, feel free to drop a comment.

@nguyenkims
Copy link
Contributor

Thanks for making the PR.
It seems that all aliases have the same websites as you can see in the below screenshot:
CleanShot 2023-05-06 at 22 06 05@2x

And we have a display error when there's no websites used:
CleanShot 2023-05-06 at 22 06 49@2x

I've thought again about the feature request and am wondering maybe this isn't relevant any more because:
a) now that in the browser extension we automatically add "Used on website.com", we can know easily where an alias is created
b) The AliasUsedOn is used to inform users that an alias has been created on a website before but I don't see the utility of this.

I think what we can do instead is to

  • update the alias note to something like "Created on website1, website2, etc" based on AliasUsedOn data for old aliases that were created before "Used on website.com" was added
  • remove the AliasUsedOn table

What do you think?

@mlec1
Copy link
Contributor Author

mlec1 commented May 8, 2023

Concerning the display issue, it should use the multipleSelect like the select for the mailboxes

image

Let me know if it is still not there after refreshing the page, reinstalling the npm packages or if you have errors in the browser console, maybe.

Concerning the usefullness of the AliasUsedOn, I personaly don't use the SL extension in my daily usage, but I think, the AliasUsedOn is used for the extension in order to autocomplete the email field by one of the aliases used for this website.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants