Add XAML #2522
Merged
Add XAML #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
After putting this PR together, I'm wondering now if this is the correct icons choice as i isn't mentioned in the final review at microsoft/microsoft-ui-xaml#1185
Hmm, based on that link and the swag they have I'm afraid the other version is actually a more reasonable choice 😅 The version in this PR seems to only be in that Figma document.
Would you mind changing it @PeterShaggyNoble (to the "single colour outline")? And maybe update the source to link to the issue/comment, I'm not sure how persistent Figma links are 🤔
|
Updated. |
|
Thanks @PeterShaggyNoble, merged this in 🎉 |
ericcornelissen
added a commit
that referenced
this pull request
Mar 1, 2020
# New icons - YouTube Studio (#2481) - Cloudsmith (#1071) - easyJet (#2598) - Aer Lingus (#2607) - Ryanair (#2606) - JSON Web Tokens (#2605) - Google Earth (#2529) - SmartThings (#2618) - GitHub Actions (#2620) - XAML (#2522) - Google Street View (#2533, #2707) - DC (#2534) - Suzuki (#2630) - Mitsubishi (#2631) - General Motors (#2638) - Tata (#2637) - Porsche (#2635) - BMW (#2626) - LineageOS (#2609) - Archicad (#2633) - Stellar (#2613) - Try It Online (#2622) - Prezi (#2623) - The Washington Post (#2655) - CNN (#2656) - CloudCannon (#2662) - Craft CMS (#2666) - micro:bit (#2624) - Cesium (#2660) - Harbor (#2650) - QIWI (#2669) - Staffbase (#2673) - 1001Tracklists (#2678) - PlayStation 2 (#2679) - Antena 3 (#2680) - FIRST (#2681) - Poly (#2682) - Spinrilla (#2696) - Platzi (#2684) - GitKraken (#2697) - Threema (#2699) - Apollo GraphQL (#2589) - OnStar (#2701) - Elm (#2702) - Iconify (#2703) - Vivino (#2705) - Pokémon (#2408) - Hive (#2674) # Updated icons - Microsoft Access (#2541) - Microsoft Excel (#2549) - Microsoft Office (#2550) - Microsoft OneDrive (#2551) - Microsoft OneNote (#2552) - Microsoft PowerPoint (#2554) - Microsoft Teams (#2556) - Wix (#2596) - Microsoft Outlook (#2553) - Google Fit (#2707) - Google Lens (#2707) - Google Pay (#2707) - Google Play (#2707) - Google Wear OS (#2707)
|
USE rejected to XAML STYLE LOGO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #2509
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
After putting this PR together, I'm wondering now if this is the correct icon choice as it isn't mentioned in the final review at microsoft/microsoft-ui-xaml#1185Original version, for reference: