Add seed argument to check_directive #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `seed` argument to `discretize.tests.check_derivative`. Make use of Numpy's random number generator to create random variables in the function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 36 36
Lines 8408 8409 +1
=======================================
+ Hits 7157 7158 +1
Misses 1251 1251 ☔ View full report in Codecov by Sentry. |
|
As mentioned in the meeting, I had started a bit on this already. I've opened a draft PR with what I had at #360 . It still needs a bit of work though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
seedargument todiscretize.tests.check_derivative. Make use of Numpy's random number generator to create random variables in the function. This would help to ensure reproducibility of tests both in discretize and SimPEG.