Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hanging CurviMesh in docstring for CurvilinearMesh #358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omid-b
Copy link

@omid-b omid-b commented Apr 29, 2024

Description for Squash and Merge

Replace CurviMesh for CurvilinearMesh in the text of the mesh overview page.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (300b64a) to head (edc06bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          36       36           
  Lines        8408     8408           
=======================================
  Hits         7157     7157           
  Misses       1251     1251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisoler
Copy link
Member

Thanks a lot @omid-b for the contribution! Nice catch of that typo!

This is ready to be merged. The tests failing in CI are surely unrelated to your change, so don't worry about them.

I'll add a description to your PR and change its title. Hope you don't mind, and feel free to edit as you please.

Thanks again!

@santisoler santisoler changed the title Update 1_mesh_overview.py Replace hanging CurviMesh in docstring for CurvilinearMesh Apr 30, 2024
@omid-b
Copy link
Author

omid-b commented Apr 30, 2024

Thank you very much for your reply and adding a better description of the PR @santisoler; it is certainly better descriptive now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants