New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for buffer zone (ie. territorial waters = 12nm) #11
Open
leeprevost
wants to merge
16
commits into
simonepri:master
Choose a base branch
from
leeprevost:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Rather than buffer zone which requires much memory and recompute, I just refactored using @geo-maps/countries-maritime-10m boundaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simonepri - this was my attempt to add buffer zone logic to your is-sea module. I updated index.js and package.json but did not update readme, demos, or test. Was not sure how to do that as I'm more comfortable with python. I thought adding the @turf/buffer module would be lighter weight than trying to import another map which has buffers drawn and would be especially 'lite' for raspi or embedded use aboard a vessel. If you can guide me on whatelse needs added, I'll surely do my best to contribute.