-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow versioning by not forcing absolute path for graph requests #180
Conversation
@simi Good catch. That was also having the same issue, I took out the leading slash but am still seeing it strip out the v2.2 when it makes the token request. I'll look into it further later on |
Also in the image_url method https://github.com/mkdynamic/omniauth-facebook/blob/master/lib/omniauth/strategies/facebook.rb#L188 you can't make versioned request. What about passing the version number in client_options? |
@matteogiacobazzi see https://github.com/mkdynamic/omniauth-facebook#api-version. I think that should be enough, we just need to ensure it is used everywhere. |
Alright I think we covered all the scenarios now where versioning was being affected |
Awesome @frausto! Thanks for your contribution. |
Allow versioning by not forcing absolute path for graph requests
Changelog note added in 9c93c08. |
Released in 2.0.1! |
Faraday assumes leading slashes are absolute paths, this prevents you from being able to set your version based on the :site. for example when site is "https://graph.facebook.com/v2.2"
lostisland/faraday#293