Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Deprecate passing non-arrays to FieldList methods #11236

Merged
merged 1 commit into from
May 16, 2024
Merged

API Deprecate passing non-arrays to FieldList methods #11236

merged 1 commit into from
May 16, 2024

Conversation

emteknetnz
Copy link
Member

Issue #11198

@emteknetnz emteknetnz mentioned this pull request May 14, 2024
Closed
GuySartorelli
GuySartorelli approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs CMS 5.3 changelog entry. Will merge when there's a PR for that.

@GuySartorelli
Copy link
Member

Tagging @emteknetnz In case you missed the above comment

@emteknetnz
Copy link
Member Author

Done silverstripe/developer-docs#514

@GuySartorelli GuySartorelli merged commit cd77301 into silverstripe:5 May 16, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/deprecate-non-array branch May 16, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emteknetnz @GuySartorelli