API Strongly type Fieldlist #11235
Merged
API Strongly type Fieldlist #11235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/6/fieldlist-strongly-type
branch
6 times, most recently
from
d538902
to
cef6ba8
Compare
GuySartorelli
requested changes
May 13, 2024
emteknetnz
force-pushed
the
pulls/6/fieldlist-strongly-type
branch
3 times, most recently
from
4b99563
to
8b6bb67
Compare
GuySartorelli
requested changes
May 14, 2024
emteknetnz
force-pushed
the
pulls/6/fieldlist-strongly-type
branch
2 times, most recently
from
4d88bde
to
68adc84
Compare
GuySartorelli
requested changes
May 15, 2024
emteknetnz
force-pushed
the
pulls/6/fieldlist-strongly-type
branch
from
68adc84
to
ce66dd8
Compare
emteknetnz
commented
May 15, 2024
emteknetnz
force-pushed
the
pulls/6/fieldlist-strongly-type
branch
from
ce66dd8
to
5e04225
Compare
GuySartorelli
requested changes
May 16, 2024
emteknetnz
force-pushed
the
pulls/6/fieldlist-strongly-type
branch
from
5e04225
to
a504477
Compare
emteknetnz
force-pushed
the
pulls/6/fieldlist-strongly-type
branch
from
a504477
to
7b847f8
Compare
GuySartorelli
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM - looks like some changes to castedCopy() were made since my last review, in the future please make sure you point out changes that happen after a review that aren't related to that review. I could have missed those, and if there were problems with them I might not have noticed the problems.
In this case the changes look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11198