Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Methods with missing nullable return types #11187

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Mar 29, 2024

Description

More phpdoc updates
Nullable return types are tricky :)

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli GuySartorelli mentioned this pull request Apr 1, 2024
4 tasks
@GuySartorelli
Copy link
Member

GuySartorelli commented Apr 1, 2024

As with all ENH commits, please target the next minor release branch, which is 5. You may need to reset your commits after changing the target branch.
5.1 or any other x.y branch is only for content that will be included in a patch release.

@GuySartorelli
Copy link
Member

Nevermind, ignore that. I just realised this is jsut PHP docs so 5.1 is fine.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@GuySartorelli GuySartorelli merged commit cca2f70 into silverstripe:5.1 Apr 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants