Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH fieldList is an array or null #11177

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Mar 14, 2024

Description

More phpdoc updates
This one is about the saveInto that is just plain wrong from what I can see

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli GuySartorelli mentioned this pull request Mar 14, 2024
4 tasks
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is_array() check is weird and hints that maybe something else could be passed in - but it's never used in a context where it isn't an array, so I'm thinking that's just defensive programming against the wrong type being passed in.

LGTM.

@GuySartorelli
Copy link
Member

GuySartorelli commented Mar 14, 2024

I won't ask for it this time because it's not a huge deal - but in the future please make sure your commit message talks about the actual change being made (e.g. ENH Set correct typehint for saveInto() param)

@GuySartorelli GuySartorelli merged commit 4e3add8 into silverstripe:5.1 Mar 14, 2024
15 checks passed
@lekoala
Copy link
Contributor Author

lekoala commented Mar 15, 2024

I won't ask for it this time because it's not a huge deal - but in the future please make sure your commit message talks about the actual change being made (e.g. ENH Set correct typehint for saveInto() param)

will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants