Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX mark a successful login attempt when completing a password reset #11176

Open
wants to merge 1 commit into
base: 5
Choose a base branch
from

Conversation

wilr
Copy link
Member

@wilr wilr commented Mar 14, 2024

Description

See issue #10100

Manual testing steps

  • Lock yourself out of a site (5 password fails)
  • Reset your password via 'Forgot Password'
  • Password reset fails as user is 'Locked out'

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@wilr wilr force-pushed the fix/reset-password-lockout branch from ecbad65 to 75c1f67 Compare March 14, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant