-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH docblock types #11168
ENH docblock types #11168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor tweak, otherwise good to merge
Can you please tick all of the appropriate checkboxes? It's intended both as a "have I done everything I need to?" checklist for you, as well as a "Is the contributor finished working on this or is it clear there is still more to do?" list for maintainers. |
Please also link to an open issue - we can't track closed issues |
Co-authored-by: Loz Calver <kinglozzer@gmail.com>
@GuySartorelli issue created #11173 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's an all 'round incremental improvement with no discernable side effects.
Please change the commit message from FIX
to either MNT
or ENH
- FIX
is for bugs that affect code, but this doesn't affect any of the actual code.
Ahh, I didn't notice this has a bunch of commits, so I'll have to squash merge anyway, so I can change the commit message during that process. |
Description
Fix/improve return types for public facing apis
Manual testing steps
Nothing, just phpstan being happy
Issues
Pull request checklist