Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Update DataObject::delete() docblock #11131

Draft
wants to merge 1 commit into
base: 5.1
Choose a base branch
from
Draft

ENH Update DataObject::delete() docblock #11131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ORM/DataObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,7 +1724,8 @@ private function skipWriteComponents($recursive, DataObject $target, array &$ski
/**
* Delete this data object.
* $this->onBeforeDelete() gets called.
* Note that in Versioned objects, both Stage and Live will be deleted.
* Note that in Versioned objects only the record from the draft table will be deleted
* If you also wish to delete the record from the live table then use Versioned::doArchive() instead
* @uses DataExtension::augmentSQL()
*/
public function delete()
Expand Down