BUG Make sure the cache shortcode value is used in FileShortcodeProvider #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
FileShortcodeProvider and ImageShortcodeProvider are using the same caching logic.
I only wrote test for FileShortcodeProvider because that's the class that contains the caching logic.
There's no security concern here about returning the cache markup for protected file:
- the previous behaviour for protected file was to query on generating the markup after a cache miss
- even if the markup reference a file you don't have access to, you'll be block once you actually try to view/download that file.
2 tasks
GuySartorelli
requested changes
Apr 29, 2024
maxime-rainville
force-pushed
the
pulls/2.2/fix-shortcode-caching
branch
from
bdc1270
to
d7f92c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue