ENH Remove duplicated default settings from cms TinyMCE config #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2/remove-default-setting
branch
from
02ca865
to
3e20207
Compare
GuySartorelli
commented
Apr 18, 2024
Comment on lines
-43
to
30
| 'extended_valid_elements' => "img[class|src|alt|title|hspace|vspace|width|height|align|name" | ||
| . "|usemap|data*],iframe[src|name|width|height|align|frameborder|marginwidth|marginheight|scrolling]," | ||
| 'extended_valid_elements' => "iframe[src|name|width|height|align|frameborder|marginwidth|marginheight|scrolling]," | ||
| . "object[width|height|data|type],param[name|value],map[class|name|id],area[shape|coords|href|target|alt]" |
There was a problem hiding this comment.
Note that the img stuff is included in the default valid_elements set so I removed that from here too.
2 tasks
emteknetnz
requested changes
Apr 18, 2024
| @@ -24,24 +24,9 @@ | |||
| 'friendly_name' => 'Default CMS', | |||
| 'priority' => '50', | |||
| 'skin' => 'silverstripe', | |||
| 'body_class' => 'typography', | |||
There was a problem hiding this comment.
That's in the set of default options already. I removed everything that is in the default options so that changing the default options will update for this as well.
emteknetnz
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires silverstripe/silverstripe-framework#11201
Removes the duplication of default settings for the cms TinyMCE config instance. This does two things:
Note that this config has some
extended_valid_elementsdefined - I've opted to not include that in the default set, because these elements aren't things you're likely to want in most of your WSIWYG fields. In a future major release we'll probably be removing these from the cms config as well.Issues
extended_valid_elementson a custom Config. silverstripe-framework#11141