Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.php #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.php #547

wants to merge 1 commit into from

Conversation

ras07
Copy link
Contributor

@ras07 ras07 commented Feb 18, 2020

was missing $ before the variable buttonCount on line 49. This didn't cause a problem (other than giving the user infinite buttons) but it results in the following message in the Apache error log:

Use of undefined constant buttonCount - assumed 'buttonCount' (this will throw an Error in a future version of PHP) in /var/www/http/index.php on line 49

was missing `$` before the variable buttonCount on line 49. This didn't cause a problem (other than giving the user infinite buttons) but it results in the following message in the Apache error log:

Use of undefined constant buttonCount - assumed 'buttonCount' (this will throw an Error in a future version of PHP) in /var/www/http/index.php on line 49
@roberttidey
Copy link
Collaborator

Thanks. I have corrected this.

@hogwell
Copy link

hogwell commented Jun 13, 2020

This code logic that limits the number of buttons to 6 is overly strict, in my opinion.
In fact, I use 10 buttons, which used to work fine before this typo was fixed.
It should really parse the "width:10%" attributes for each button and instead check that the total doesn't exceed 100%.

@roberttidey
Copy link
Collaborator

I have upped the maximum user button count to 12. No specific check on widths. I think they will wrap if width is exceeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants