New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete_object with nil object_id #37

Open

marciotoze wants to merge 1 commit into sikanhe:master from marciotoze:fix-delete-object-with-nil

marciotoze commented Sep 27, 2021

Today if you call Algolia.delete_object("index_name", nil) its delete the entire index.

this is because the delete index route is the same as delete object without the object id, see algolia docs

DELETE /1/indexes/{indexName}/{objectID} # delete object path
DELETE /1/indexes/{indexName}/           # delete index path

so Paths module builds the delete index path when object_id nil

iex(1)> Algolia.Paths.object("index", "1")
"/1/indexes/index/1"
iex(2)> Algolia.Paths.object("index", nil)
"/1/indexes/index/"


          Fix delete_object with nil object_id

4a7c17f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment